2008年7月14日

[mew-dist 28524] Re: toolbar icon on Emacs23

山本です。

> image-load-path には data-directory というシンボルが含まれているので、
> data-directory の内容を動的に反映させようと言う意図が伺えます。
> なので、単に CVS HEAD のバグではないでしょうか?
>
> #グローバル変数(image-load-path)を勝手に書き換えるのは気が引けます。。。
>

> emacs-devel で聞いてみますね。

添付のように、その内、直るでしょう。

--かず

Return-Path: <monnier@xxxxx>
Received: OTM-IMAP id m6BDagX8003118; Fri, 11 Jul 2008 22:36:42 +0900
Received: --OF MDI (mdi30) id m6BDagU3007655; Fri, 11 Jul 2008 22:36:42 +0900
Received: OTM-MIX(otm-mix01) id m6BDagNt096220;
Fri, 11 Jul 2008 22:36:42 +0900 (JST)
Received: from unknown [192.168.176.53] (EHLO otm-mgi00.iij.ad.jp)
by otm-mas00.iij.ad.jp (mxl_mta-3.1.0-05)
with ESMTP id 9e167784.320543664.7472.00-001.otm-mas00.iij.ad.jp
(envelope-from <monnier@xxxxx>);
Fri, 11 Jul 2008 22:36:41 +0900 (JST)
Authentication-Results: omgi.iij.ad.jp header.From=monnier@xxxxx;
dkim=none
Authentication-Results: omgi.iij.ad.jp smtp.mail=monnier@xxxxx;
spf=softfail
Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca
[206.248.154.182])
by omgi.iij.ad.jp (OTM-MI/otm-mgi00) id m6BDadNO003577
for <kazu@xxxxx>; Fri, 11 Jul 2008 22:36:40 +0900 (JST)
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: ApkEADH/dkjO+IfCdGdsb2JhbACBWpBNASedDoFo
X-IronPort-AV: E=Sophos;i="4.30,345,1212379200"; d="scan'208";a="24224167"
Received: from 206-248-135-194.dsl.teksavvy.com (HELO pastel.home)
([206.248.135.194])
by ironport2-out.teksavvy.com with ESMTP; 11 Jul 2008 09:36:37 -0400
Received: by pastel.home (Postfix, from userid 20848)
id BD4158474; Fri, 11 Jul 2008 09:36:32 -0400 (EDT)
From: Stefan Monnier <monnier@xxxxx>
To: Kazu Yamamoto (=?utf-8?B?5bGx5pys5ZKM5b2m?=) <kazu@xxxxx>
Cc: emacs-devel@xxxxx
Subject: Re: data-directory
Message-ID: <jwvzloolf33.fsf-monnier+emacs@xxxxx>
References: <20080711.182017.41977074.kazu@xxxxx>
Date: Fri, 11 Jul 2008 09:36:32 -0400
In-Reply-To: <20080711.182017.41977074.kazu@xxxxx> ("Kazu Yamamoto
=?utf-8?B?KOWxseacrOWSjAnlvaYpIidz?= message of "Fri,
11 Jul 2008 18:20:17 +0900 (JST)")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam: [F=0.1000000000; CM=0.500; S=0.100(2008062001); MH=0.500(2008071106);
SC=none]
X-MAIL-FROM: <monnier@xxxxx>
X-SOURCE-IP: [192.168.176.53]
X-AnalysisOut: [v=1.0 c=0 a=zJYGr7CltEMjBLEjlJ8A:9 a=1a77SmOCn11OygaexIwA:]
X-AnalysisOut: [7 a=9G3P6OfXxOIewlq2AjU5enagsRkA:4 a=MxZ3bB5I4kYA:10]

> (defun mew-toolbar-make (map alist)
> (let ((tool-bar-map (make-sparse-keymap)) ;; for tool-bar-add-item-from-menu
> (data-directory mew-icon-directory))
> (dolist (a alist)
> (if (fboundp 'tool-bar-local-item-from-menu)
> ;; Emacs 21.3.50 or later
> (tool-bar-local-item-from-menu (car a) (cdr a) tool-bar-map map)
> ;; Emacs 21.3 or earlier
> ;; The target map is tool-bar-map
> (tool-bar-add-item-from-menu (car a) (cdr a) map)))
> tool-bar-map))

> On Emacs 22, the tool-bar is created correctly. However, on CVS HEAD
> Emacs, icon images are not displayed.

> image-load-path contains the data-directory symbol. So, I think the
> locally bound value to data-directory should be used.

> Is this behavior change intentional? Or just a bug?

It's neither a bug nor intentional. ;-)
The image selection has now been postponed to the point when the toolbar
is displayed, which is outside of the scope of the let.
I'll see how we can try and remember the data-directory.


Stefan

投稿者 xml-rpc : 2008年7月14日 15:39
役に立ちました?:
過去のフィードバック 平均:(0) 総合:(0) 投票回数:(0)
本記事へのTrackback: http://hoop.euqset.org/blog/mt-tb2006.cgi/75253
トラックバック
コメント
コメントする




画像の中に見える文字を入力してください。